Fix Xcode defines that contain quotes #562
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change defines that contain quotes (for example #define "some/path") are handled incorrectly in Xcode. Xcode would interpret the quotes and they would not appear in the define, breaking the build. This seems to work correctly in Linux and on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change defines that contain quotes (for example
#define "some/path") are handled incorrectly in Xcode. Xcode would interpret the quotes and they would not appear in the define (#define some/path), breaking the build.This seems to work correctly in Linux and on Windows, so this was breaking our multiplatform builds.
The fix is based on https://github.com/premake/premake-core/blob/master/modules/xcode/xcode_common.lua#L167
I am not sure if c95e8f5 is related, maybe it just made sure that the quotes get correctly to Xcode, but certainly did not prevent Xcode from interpreting them.